[Skiboot] [PATCH v2 16/16] npu2-opencapi: Log a warning when resetting a broken device

christophe lombard clombard at linux.vnet.ibm.com
Mon Oct 14 23:44:35 AEDT 2019


On 09/10/2019 21:38, Frederic Barrat wrote:
> On P9, the NPU doesn't support recovery if the link goes down
> unexpectedly. It was not fully verified. We mark the device as broken
> when we receive an error interrupt from the NPU. However, there's
> nothing to prevent the OS from trying to reset the device; It may or
> may not work, it's unsupported territory, so let's log a message to
> make it clear, as it could help when debugging. We haven't hit any
> cases where the reset goes badly enough that we'd want to prevent it,
> so let it go for now. We can revisit later if we have evidence that
> it's causing more problems than it is worth.
> 
> Signed-off-by: Frederic Barrat <fbarrat at linux.ibm.com>
> ---

Reviewed-by: Christophe Lombard <clombard at linux.vnet.ibm.com>



More information about the Skiboot mailing list