[Skiboot] [PATCH] chip: enable HOMER/OCC common area region in Qemu emulated PowerNV host

Cédric Le Goater clg at kaod.org
Mon Oct 14 20:54:14 AEDT 2019


On 14/10/2019 11:48, Balamuruhan S wrote:
> Recent work on Qemu adds support to emulate homer memory region and occ
> common area region with respective device models, so remove `QUIRK_NO_PBA`
> to enable HOMER/OCC common area region code for Qemu emulated PowerNV host.

ok. But you are adding : QUIRK_NO_DIRECT_CTL. Why ?

C.

> 
> Signed-off-by: Balamuruhan S <bala24 at linux.ibm.com>
> ---
>  core/chip.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/core/chip.c b/core/chip.c
> index 4a4a9a27..d4257df9 100644
> --- a/core/chip.c
> +++ b/core/chip.c
> @@ -133,7 +133,7 @@ void init_chips(void)
>  	if (dt_node_is_compatible(dt_root, "qemu,powernv") ||
>  	    dt_node_is_compatible(dt_root, "qemu,powernv8") ||
>  	    dt_node_is_compatible(dt_root, "qemu,powernv9")) {
> -		proc_chip_quirks |= QUIRK_NO_CHIPTOD | QUIRK_NO_PBA
> +		proc_chip_quirks |= QUIRK_NO_CHIPTOD
>  			| QUIRK_NO_DIRECT_CTL | QUIRK_NO_RNG;
>  		prlog(PR_NOTICE, "CHIP: Detected Qemu simulator\n");
>  	}
> 



More information about the Skiboot mailing list