[Skiboot] [PATCH v4 01/15] asm/cvc_entry.S: r2 save fix
npiggin at gmail.com
Sun Oct 13 09:22:43 AEDT 2019
Stewart Smith's on October 11, 2019 1:13 am:
> On Wed, Oct 9, 2019, at 4:49 PM, Nicholas Piggin wrote:
>> The TOC save area for the current stack frame should be used to save
>> r2, not the caller's frame.
>> Signed-off-by: Nicholas Piggin <npiggin at gmail.com>
>> asm/cvc_entry.S | 9 +++++++--
>> include/stack.h | 2 ++
>> 2 files changed, 9 insertions(+), 2 deletions(-)
>> diff --git a/asm/cvc_entry.S b/asm/cvc_entry.S
>> index 1296e88fe..3e8b3fdad 100644
>> --- a/asm/cvc_entry.S
>> +++ b/asm/cvc_entry.S
>> @@ -24,6 +24,11 @@
>> #.include "kernel/ppcconsts.S"
>> +# Updated hostboot location is src/securerom/rom_entry.S.
>> +# This also has a fix for TOC save frame pointer.
> Should probably also go to hostboot?
> Acked-by: Stewart Smith <stewart at flamingspork.com>
Yeah I pinged hostboot about it.
More information about the Skiboot