[Skiboot] [PATCH 2/2] core/init: Checksum romem after patching out traps

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Fri Oct 11 21:16:46 AEDT 2019

On 10/11/19 9:57 AM, Oliver O'Halloran wrote:
> Currently we checksum the read-only parts of skiboot's memory just
> before loading and booting petitboot. Commit 9ddc1a6bfaef
> ("core/util: trap based assertions") modifies the .text after this
> point since it needs to disable the trap instructions that we use
> to trigger an abort() before entering the kernel.
> We can fix this by moving the checksum to after the point where the
> traps are patched out. We could do the patching sooner, but since
> load_and_boot_kernel() is a fairly complex function it's perferable
> to keep boot-time assertion infrastructure active until just before
> we enter the kernel.
> Reported-by: Carol L Soto <clsoto at us.ibm.com>
> Fixes: 9ddc1a6bfaef ("core/util: trap based assertions")
> Signed-off-by: Oliver O'Halloran <oohall at gmail.com>

Looks good to me and it fixed fast-reboot issue.

Tested-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>


More information about the Skiboot mailing list