[Skiboot] [PATCH v4 03/15] capp: fix endian conversion

Stewart Smith stewart at flamingspork.com
Fri Oct 11 02:10:29 AEDT 2019


On Wed, Oct 9, 2019, at 4:49 PM, Nicholas Piggin wrote:
> Signed-off-by: Nicholas Piggin <npiggin at gmail.com>
> ---
>  hw/capp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/capp.c b/hw/capp.c
> index 709e6db14..269deb637 100644
> --- a/hw/capp.c
> +++ b/hw/capp.c
> @@ -168,7 +168,7 @@ int64_t capp_load_ucode(unsigned int chip_id, 
> uint32_t opal_id,
>  
>  	/* 'CAPPULID' in ASCII */
>  	if ((be64_to_cpu(ucode->eyecatcher) != 0x43415050554C4944UL) ||
> -	    (be64_to_cpu(ucode->version != 1))) {
> +	    (be64_to_cpu(ucode->version) != 1)) {
>  		PHBERR(opal_id, chip_id, index,
>  		       "CAPP: ucode header invalid\n");
>  		return OPAL_HARDWARE;

I'm sure the git-blame firmly blames me in some way for that. Whoops.

Acked-by: Stewart Smith <stewart at flamingspork.com>


More information about the Skiboot mailing list