[Skiboot] [PATCH v3 02/14] capp: fix endian conversion

[Andrew Donnellan]

On 4/10/19 6:02 am, Nicholas Piggin wrote:
> Signed-off-by: Nicholas Piggin <npiggin at gmail.com>

Sigh. Thanks for picking this up.

Reviewed-by: Andrew Donnellan <ajd at linux.ibm.com>

> ---
>   hw/capp.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/capp.c b/hw/capp.c
> index 709e6db14..269deb637 100644
> --- a/hw/capp.c
> +++ b/hw/capp.c
> @@ -168,7 +168,7 @@ int64_t capp_load_ucode(unsigned int chip_id, uint32_t opal_id,
>   
>   	/* 'CAPPULID' in ASCII */
>   	if ((be64_to_cpu(ucode->eyecatcher) != 0x43415050554C4944UL) ||
> -	    (be64_to_cpu(ucode->version != 1))) {
> +	    (be64_to_cpu(ucode->version) != 1)) {
>   		PHBERR(opal_id, chip_id, index,
>   		       "CAPP: ucode header invalid\n");
>   		return OPAL_HARDWARE;
> 

-- 
Andrew Donnellan              OzLabs, ADL Canberra
ajd at linux.ibm.com             IBM Australia Limited