[Skiboot] [PATCH 08/12] xive: make endian-clean
npiggin at gmail.com
Wed Oct 2 14:29:50 AEST 2019
Oliver O'Halloran's on October 1, 2019 3:24 pm:
> On Sun, 2019-09-29 at 17:46 +1000, Nicholas Piggin wrote:
>> Convert xive opal calls, dt construction, and in-memory hardware tables
>> to use explicit endian conversions.
> Cedric, ack/nak?
> I'm a bit iffy about the __prefixes since the in-memory tables are
> homogenously BE. If we're going to be more concerned about endian
> safety going forward I'd prefer we use the __beXX annotations and some
> kind of automated checking rather than ad-hoc conventions.
Yeah good point about that. I actually renamed those only to get the
compiler to tell me about anything I had missed. I really intended to
rename them back in a final patch.
Cedric has some accessor scheme that sounds like it will make this a
lot tidier too.
More information about the Skiboot