[Skiboot] [PATCH v7 18/26] fsp: endian conversions

[Vasant Hegde]

On 11/11/19 11:19 AM, Nicholas Piggin wrote:
> Reviewed-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
> Signed-off-by: Nicholas Piggin <npiggin at gmail.com>
> ---
>   hw/fsp/fsp-codeupdate.c |  4 +-
>   hw/fsp/fsp-codeupdate.h | 86 ++++++++++++++++++++---------------------
>   hw/fsp/fsp-sysdump.c    |  2 +-
>   hw/fsp/fsp-sysparam.c   |  2 +-
>   hw/fsp/fsp.c            | 16 ++++----


I tried to look into couple of drivers under hw/fsp/* (not yet looked into all 
files).
Here are few places we need fixes.

hw/fsp/fsp-attn.c

109         ti_attn->msg_len = VERSION_LEN + BT_FRAME_LEN +
110                                    strlen(ti_attn->msg.file_info);
111 }


hw/fsp/fsp-dump.c

376         *dump_id = record->id;
377         *dump_size = record->size;
378         *dump_type = record->type;

Data returned by fsp_get_sys_param() needs to be converted (we do TCE mapping of 
buffer and FSP
will fill BE data).


I tried to boot ZZ with this patch series (both LE and BE mode). its not booting 
for me. I suspect HDAT related changes causing some issue (haven't looked into 
it in detail).

fsp_mkmsg() usage needs careful audit .. as fsp_wreg() -> out_be32() converts 
data from cpu_to_be().


-Vasant