[Skiboot] [PATCH v2 6/9] fsp: map trace areas on P9

Nicholas Piggin npiggin at gmail.com
Mon Nov 11 16:44:45 AEDT 2019


P7 did not have enough PSI TCEs to map trace buffers, and so it was
P8 only, and not updated for P9 despite P9 having 256KB

Signed-off-by: Nicholas Piggin <npiggin at gmail.com>
---
 include/psi.h              | 5 ++---
 platforms/ibm-fsp/common.c | 6 ------
 2 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/include/psi.h b/include/psi.h
index ee1e0a7ae..8e3f18841 100644
--- a/include/psi.h
+++ b/include/psi.h
@@ -142,8 +142,8 @@
 /*
  * Layout of the PSI DMA address space
  *
- * On P8, we use a larger mapping of 256K TCEs which provides
- * us with a 1G window in order to fit the trace buffers
+ * We use a larger mapping of 256K TCEs which provides us with a 1G window in
+ * order to fit the trace buffers
  *
  * Currently we have:
  *
@@ -215,7 +215,6 @@
 #define PSI_DMA_HBRT_FSP_MSG		0x03302000
 #define PSI_DMA_HBRT_FSP_MSG_SIZE	0x00011000
 
-/* P8 only mappings */
 #define PSI_DMA_TRACE_BASE		0x04000000
 
 struct psi {
diff --git a/platforms/ibm-fsp/common.c b/platforms/ibm-fsp/common.c
index a0339ec25..1ad221053 100644
--- a/platforms/ibm-fsp/common.c
+++ b/platforms/ibm-fsp/common.c
@@ -30,12 +30,6 @@ static void map_debug_areas(void)
 	t = memcons.ibuf_phys - INMEM_CON_START + PSI_DMA_LOG_BUF;
 	debug_descriptor.memcons_ibuf_tce = t;
 
-	/* We only have space in the TCE table for the trace
-	 * areas on P8
-	 */
-	if (proc_gen != proc_gen_p8)
-		return;
-
 	t = PSI_DMA_TRACE_BASE;
 	for (i = 0; i < debug_descriptor.num_traces; i++) {
 		/*
-- 
2.23.0



More information about the Skiboot mailing list