[Skiboot] [PATCH] prd: Fix prd message queuing interface

Oliver O'Halloran oohall at gmail.com
Fri Nov 8 16:02:29 AEDT 2019


On Tue, Oct 22, 2019 at 10:28 PM Vasant Hegde
<hegdevasant at linux.vnet.ibm.com> wrote:
>
> OPAL_MSG_PRD interface can handle message size <= OPAL_MSG_FIXED_PARAMS_SIZE.
> But kernel prd driver had a bug where it will not copy partial data to user
> space. This will create problem as opal-prd daemon tries to read message
> continuously.
>
> Commit 9cae036fa fixed this issue by enhancing opal-prd to allocate bigger
> message size based on device tree.
>
> For backward compatability (new OPAL and old kernel/userspace) lets restrict
> OPAL_MSG_PRD messaging interface to send upto 32 bytes data. This is fine
> as most of the messages are less than 32 bytes except FSP - HBRT messages
> ...which is new feature.
>
> Cc: Jeremy Kerr <jk at ozlabs.org>
> Cc: Vaidyanathan Srinivasan <svaidy at linux.vnet.ibm.com>
> Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>

Merged as 790a604e37206569506e3552dbf6b583656c7ab1


More information about the Skiboot mailing list