[Skiboot] [PATCH 2/3] platforms/qemu: Add slot table

[Oliver O'Halloran]

On Tue, Nov 5, 2019 at 11:34 PM Cédric Le Goater <clg at kaod.org> wrote:
>
> On 05/11/2019 08:43, Oliver O'Halloran wrote:
> > Add a slot table to our QEMU platform file to allow testing slot
> > functions and so that we have the basic infrastructure in place. The
> > slot names are the bus names that Qemu assigns to the subordiate bus of the
>
> subordinate ?

Er, yeah. I woke up at 5:30am and words are not my friends even at the
best of times.

> > root port (i.e. where actual devices should go).
> >
> > Devices can be added under a specific phb by specifying that bus. E.g.
> >
> >         -drive file=./disk1.img,format=raw,if=none,id=nvme0 \
> >         -device nvme,drive=nvme0,bus=pcie.1
> >
> > Places an NVMe device under the root port of PHB0001.
> >
> > The six slots here will cover each of the six PHBs that exist in the
> > default P9 model. The P8 model has three (since that's what a Venice
> > has), but the extra slots shouldn't cause any problems.
>
> On the P8 topic, you need to know that I dropped the PHB3 model from
> the QEMU powernv branch because of a cleanup of the XICS models in
> mainstream. Tell me if this is "critical" and may be we can find
> someone to do the backports.

No big deal. I only mentioned it because last time I checked P8 and
PHB3 was still the default setting CPU for the powernv model. I guess
that's out of date at this point.

Oiver