[Skiboot] [PATCH 078/110] Remove unused OPAL_PCI_GET_XIVE_REISSUE and OPAL_PCI_SET_XIVE_REISSUE
Andrew Donnellan
ajd at linux.ibm.com
Fri May 31 16:35:54 AEST 2019
On 31/5/19 4:13 pm, Stewart Smith wrote:
> These seem to be remnants of one of the OPAL incarnations prior to
> OPALv3. These calls have never been implemented in skiboot, and never
> used by an upstream kernel (nor a PowerKVM kernel).
>
> It's rather safe to just document them as never existing.
>
> Signed-off-by: Stewart Smith <stewart at linux.ibm.com>
Reviewed-by: Andrew Donnellan <ajd at linux.ibm.com>
> ---
> core/pci-opal.c | 20 -------------
> doc/opal-api/index.rst | 28 +++++++++++++++++--
> .../opal-pci-get-set-xive-reissue-35-36.rst | 18 ------------
> include/opal-api.h | 4 +--
> 4 files changed, 28 insertions(+), 42 deletions(-)
> delete mode 100644 doc/opal-api/opal-pci-get-set-xive-reissue-35-36.rst
>
> diff --git a/core/pci-opal.c b/core/pci-opal.c
> index 9b8d4000490b..2d2178681fb7 100644
> --- a/core/pci-opal.c
> +++ b/core/pci-opal.c
> @@ -321,26 +321,6 @@ static int64_t opal_pci_set_mve_enable(uint64_t phb_id, uint32_t mve_number,
> }
> opal_call(OPAL_PCI_SET_MVE_ENABLE, opal_pci_set_mve_enable, 3);
>
> -static int64_t opal_pci_get_xive_reissue(uint64_t phb_id __unused,
> - uint32_t xive_number __unused,
> - uint8_t *p_bit __unused,
> - uint8_t *q_bit __unused)
> -{
> - /* IODA2 (P8) stuff, TODO */
> - return OPAL_UNSUPPORTED;
> -}
> -opal_call(OPAL_PCI_GET_XIVE_REISSUE, opal_pci_get_xive_reissue, 4);
> -
> -static int64_t opal_pci_set_xive_reissue(uint64_t phb_id __unused,
> - uint32_t xive_number __unused,
> - uint8_t p_bit __unused,
> - uint8_t q_bit __unused)
> -{
> - /* IODA2 (P8) stuff, TODO */
> - return OPAL_UNSUPPORTED;
> -}
> -opal_call(OPAL_PCI_SET_XIVE_REISSUE, opal_pci_set_xive_reissue, 4);
> -
> static int64_t opal_pci_msi_eoi(uint64_t phb_id,
> uint32_t hwirq)
> {
> diff --git a/doc/opal-api/index.rst b/doc/opal-api/index.rst
> index 6e7a8a16869f..1c9af3953f25 100644
> --- a/doc/opal-api/index.rst
> +++ b/doc/opal-api/index.rst
> @@ -89,9 +89,11 @@ The OPAL API is the interface between an Operating System and OPAL.
> +---------------------------------------------+--------------+------------------------+----------+-----------------+
> | :ref:`OPAL_PCI_SET_MVE_ENABLE` | 34 | v1.0 (Initial Release) | POWER8 | |
> +---------------------------------------------+--------------+------------------------+----------+-----------------+
> -| :ref:`OPAL_PCI_GET_XIVE_REISSUE` | 35 | v1.0 (Initial Release) | POWER8 | |
> +| :ref:`OPAL_PCI_GET_XIVE_REISSUE` | 35 | Never | | Never used or |
> +| | | | | Implemented |
> +---------------------------------------------+--------------+------------------------+----------+-----------------+
> -| :ref:`OPAL_PCI_SET_XIVE_REISSUE` | 36 | v1.0 (Initial Release) | POWER8 | |
> +| :ref:`OPAL_PCI_SET_XIVE_REISSUE` | 36 | Never | | Never used or |
> +| | | | | Implemented |
> +---------------------------------------------+--------------+------------------------+----------+-----------------+
> | :ref:`OPAL_PCI_SET_XIVE_PE` | 37 | v1.0 (Initial Release) | POWER8 | |
> +---------------------------------------------+--------------+------------------------+----------+-----------------+
> @@ -390,6 +392,10 @@ removed and no longer supported.
> +---------------------------------------------+-------+-----------------------+-----------------------+
> | :ref:`OPAL_PCI_SET_PHB_TABLE_MEMORY` | 30 | Never | |
> +---------------------------------------------+-------+-----------------------+-----------------------+
> +| :ref:`OPAL_PCI_GET_XIVE_REISSUE` | 35 | Never | |
> ++---------------------------------------------+-------+-----------------------+-----------------------+
> +| :ref:`OPAL_PCI_GET_XIVE_REISSUE` | 36 | Never | |
> ++---------------------------------------------+-------+-----------------------+-----------------------+
> | :ref:`OPAL_WRITE_OPPANEL` | 43 | pre-v1.0 | pre-v1.0 |
> +---------------------------------------------+-------+-----------------------+-----------------------+
> | :ref:`OPAL_OLD_I2C_REQUEST` | 106 | v4.0 | v4.0 |
> @@ -430,6 +436,24 @@ OPAL_PCI_SET_PHB_TABLE_MEMORY
> A remnant of an old API design. Never implemented, never used. Only ever
> returned :ref:`OPAL_UNSUPPORTED`, now the call is not implemented at all.
>
> +.. _OPAL_PCI_GET_XIVE_REISSUE:
> +
> +OPAL_PCI_GET_XIVE_REISSUE
> +^^^^^^^^^^^^^^^^^^^^^^^^^
> +
> +A remnant of something prior to OPALv3. Never implemented in skiboot and never
> +used by anyone. Returend :ref:`OPAL_UNSUPPORTED` until :ref:`skiboot-6.4`, where
> +it was removed.
> +
> +.. _OPAL_PCI_SET_XIVE_REISSUE:
> +
> +OPAL_PCI_SET_XIVE_REISSUE
> +^^^^^^^^^^^^^^^^^^^^^^^^^
> +
> +A remnant of something prior to OPALv3. Never implemented in skiboot and never
> +used by anyone. Returend :ref:`OPAL_UNSUPPORTED` until :ref:`skiboot-6.4`, where
> +it was removed.
> +
> .. _OPAL_WRITE_OPPANEL:
>
> OPAL_WRITE_OPPANEL
> diff --git a/doc/opal-api/opal-pci-get-set-xive-reissue-35-36.rst b/doc/opal-api/opal-pci-get-set-xive-reissue-35-36.rst
> deleted file mode 100644
> index 5c4e68573aeb..000000000000
> --- a/doc/opal-api/opal-pci-get-set-xive-reissue-35-36.rst
> +++ /dev/null
> @@ -1,18 +0,0 @@
> -OPAL_PCI_GET_XIVE_REISSUE and OPAL_PCI_SET_XIVE_REISSUE
> -=======================================================
> -::
> -
> - static int64_t opal_pci_get_xive_reissue(uint64_t phb_id __unused,
> - uint32_t xive_number __unused,
> - uint8_t *p_bit __unused,
> - uint8_t *q_bit __unused)
> -
> - static int64_t opal_pci_set_xive_reissue(uint64_t phb_id __unused,
> - uint32_t xive_number __unused,
> - uint8_t p_bit __unused,
> - uint8_t q_bit __unused)
> -
> -
> -Both of these calls are remnants from previous OPAL versions, calling either
> -of them shall return ``OPAL_UNSUPPORTED``.
> -
> diff --git a/include/opal-api.h b/include/opal-api.h
> index f767d3c199a9..b7facf41fdbf 100644
> --- a/include/opal-api.h
> +++ b/include/opal-api.h
> @@ -94,8 +94,8 @@
> #define OPAL_PCI_SET_PELTV 32
> #define OPAL_PCI_SET_MVE 33
> #define OPAL_PCI_SET_MVE_ENABLE 34
> -#define OPAL_PCI_GET_XIVE_REISSUE 35
> -#define OPAL_PCI_SET_XIVE_REISSUE 36
> +#define OPAL_PCI_GET_XIVE_REISSUE 35 /* never implemented */
> +#define OPAL_PCI_SET_XIVE_REISSUE 36 /* never implemented */
> #define OPAL_PCI_SET_XIVE_PE 37
> #define OPAL_GET_XIVE_SOURCE 38
> #define OPAL_GET_MSI_32 39
>
--
Andrew Donnellan OzLabs, ADL Canberra
ajd at linux.ibm.com IBM Australia Limited
More information about the Skiboot
mailing list