[Skiboot] [PATCH 011/110] doc: prettify OPAL powercap docs

Stewart Smith stewart at linux.ibm.com
Fri May 31 16:12:12 AEST 2019


Signed-off-by: Stewart Smith <stewart at linux.ibm.com>
---
 .../ibm,opal/power-mgt/powercap.rst           |  4 +-
 doc/opal-api/opal-powercap.rst                | 60 ++++++++++---------
 2 files changed, 35 insertions(+), 29 deletions(-)

diff --git a/doc/device-tree/ibm,opal/power-mgt/powercap.rst b/doc/device-tree/ibm,opal/power-mgt/powercap.rst
index 5d24ee15a0ed..e59f6c28354b 100644
--- a/doc/device-tree/ibm,opal/power-mgt/powercap.rst
+++ b/doc/device-tree/ibm,opal/power-mgt/powercap.rst
@@ -1,3 +1,5 @@
+.. _device-tree/ibm,opal/power-mgt/powercap:
+
 power-mgt/powercap
 ------------------
 
@@ -8,7 +10,7 @@ For example : ::
 
         system-powercap/
 
-The OPAL_GET_POWERCAP and OPAL_SET_POWERCAP calls take a handle for
+The :ref:`OPAL_GET_POWERCAP` and :ref:`OPAL_SET_POWERCAP` calls take a handle for
 what powercap property to get/set which is defined in the child node.
 
 The compatible property for the linux driver which will be
diff --git a/doc/opal-api/opal-powercap.rst b/doc/opal-api/opal-powercap.rst
index a49d7e7df23b..6ff4d5cca87d 100644
--- a/doc/opal-api/opal-powercap.rst
+++ b/doc/opal-api/opal-powercap.rst
@@ -1,7 +1,20 @@
 .. _opal-powercap:
 
+===============
+OPAL Power Caps
+===============
+
+Each entity that can be power capped is described in the device tree,
+see :ref:`device-tree/ibm,opal/power-mgt/powercap`. The values for each
+power cap aren't in the device tree, but rather fetched using the
+:ref:`OPAL_GET_POWERCAP` OPAL call. This is because there may be other
+entities such as a service processor that can change the nature of the
+power cap asynchronously to OPAL.
+
+.. _OPAL_GET_POWERCAP:
+
 OPAL_GET_POWERCAP
-==================
+=================
 The OPAL_GET_POWERCAP call retreives current information on the power
 cap.
 
@@ -30,24 +43,22 @@ u32 \*pcap
 Returns
 -------
 
-OPAL_SUCCESS
+:ref:`OPAL_SUCCESS`
   Success
-
-OPAL_PARAMETER
+:ref:`OPAL_PARAMETER`
   Invalid pcap pointer
-
-OPAL_UNSUPPORTED
+:ref:`OPAL_UNSUPPORTED`
   No support for reading powercap sensor
-
-OPAL_HARDWARE
+:ref:`OPAL_HARDWARE`
   Unable to procced due to the current hardware state
-
-OPAL_ASYNC_COMPLETION
+:ref:`OPAL_ASYNC_COMPLETION`
   Request was sent and an async completion message will be sent with
   token and status of the request.
 
+.. _OPAL_SET_POWERCAP:
+
 OPAL_SET_POWERCAP
-============================
+=================
 The OPAL_SET_POWERCAP call sets a power cap.
 
 For each entity that can be power capped, the device tree
@@ -71,30 +82,23 @@ Parameters
 
 Returns
 -------
-OPAL_SUCCESS
-  Success
 
-OPAL_PARAMETER
+:ref:`OPAL_SUCCESS`
+  Success
+:ref:`OPAL_PARAMETER`
   Invalid powercap requested beyond powercap limits
-
-OPAL_UNSUPPORTED
+:ref:`OPAL_UNSUPPORTED`
   No support for changing the powercap
-
-OPAL_PERMISSION
+:ref:`OPAL_PERMISSION`
   Hardware cannot take the request
-
-OPAL_ASYNC_COMPLETION
+:ref:`OPAL_ASYNC_COMPLETION`
   Request was sent and an async completion message will be sent with
   token and status of the request.
-
-OPAL_HARDWARE
+:ref:`OPAL_HARDWARE`
   Unable to procced due to the current hardware state
-
-OPAL_BUSY
+:ref:`OPAL_BUSY`
   Previous request in progress
-
-OPAL_INTERNAL_ERROR
+:ref:`OPAL_INTERNAL_ERROR`
   Error in request response
-
-OPAL_TIMEOUT
+:ref:`OPAL_TIMEOUT`
   Timeout in request completion
-- 
2.21.0



More information about the Skiboot mailing list