[Skiboot] [PATCH v4 04/10] opal-msg: Enhance opal-get-msg API

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Thu May 30 15:06:23 AEST 2019


On 05/30/2019 09:10 AM, Stewart Smith wrote:
> Vasant Hegde <hegdevasant at linux.vnet.ibm.com> writes:
>> On 05/21/2019 12:50 PM, Stewart Smith wrote:
>>> Vasant Hegde <hegdevasant at linux.vnet.ibm.com> writes:
>>>

.../...

>>
>> OPAL_PARTIAL
>>      If pending opal message is greater than supplied buffer.
>>      In this case the message is *DISCARDED* by OPAL.
>>
>> ...and this patch retains above behavior. i.e. we remove entry from list and return
>> OPAL_PARTIAL to kernel.
> 
> Ahh excellent.
> 
> Oh look, some guy named Stewart wrote that nearly 3 years ago.
> 

Yes :-)

.../..

>>>
>>> So I think we need to ensure two things:
>>> 1) we don't lose unrecoverable HMIs
>>> 2) existing kernels degrade gracefully.
>>
>> I think both are taken care.
> 
> Has it been tested?

Yes. I had custom patch to inject bigger message size and tested
with both old and new kernel.

-Vasant



More information about the Skiboot mailing list