[Skiboot] [PATCH v7 04/22] hdata: Define various DUMP related tables

[Vasant Hegde]

On 05/20/2019 09:24 AM, Michael Neuling wrote:
> 
>>>> +/*
>>>> + * Processor Dump Area
>>>> + *
>>>> + * This contains the information needed for having processor
>>>> + * state captured during a platform dump.
>>>> + */
>>>> +struct proc_dump_area {
>>>> +	__be32	thread_size;	/* Size of each thread register entry */
>>>> +#define PROC_DUMP_AREA_FORMAT_P9	0x1	/* P9 format */
>>>
>>> This is P9 only?
>>
>> Right now yes. its P9 only. No support on P8.
> 
> So this means distros would still need to support kdump on p8.

Yes. This is due to firmware limitation.

> 
>>>> +/* Architected register data content */
>>>> +#define ARCH_REG_TYPE_GPR	0x01
>>>> +#define ARCH_REG_TYPE_SPR	0x02
>>>
>>> What about VSX registers?
>>
>> Right now we are collecting only GPR/SPR ..which are needed for debugging OPAL
>> core and vmcore. If we need more registers for debugging, we can add it later.
> 
> We do use VMX in the kernel for a bunch of things like memcpy and obviously
> context switch.  We'd lose some info there without vector registers.
> 
> Not to mention TM checkpointed state.

Agree. But we can add those registers. We will add those registers later. For now
I'm focusing on getting base infrastructure working.

-Vasant