[Skiboot] [PATCH v2] nvram: Flag dangerous NVRAM options

Stewart Smith stewart at linux.ibm.com
Fri May 17 08:26:34 AEST 2019


Michael Neuling <mikey at neuling.org> writes:
> Most nvram options used by skiboot are just for debug or testing for
> regressions. They should never be used long term.
>
> We've hit a number of issues in testing and the field where nvram
> options have been set "temporarily" but haven't been properly cleared
> after, resulting in crashes or real bugs being masked.
>
> This patch marks most nvram options used by skiboot as dangerous and
> prints a chicken to remind users of the problem.
>
> Signed-off-by: Michael Neuling <mikey at neuling.org>
> Reviewed-by: Samuel Mendoza-Jonas <sam at mendozajonas.com>
> Acked-By: Alistair Popple <alistair at popple.id.au>

Enthusiastically merged as of 5beda3c6fe5b72aac95b4c13746ae598dfd64c01


-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list