[Skiboot] [PATCH] core/fast-reboot: Add im-feeling-lucky option

Andrew Donnellan ajd at linux.ibm.com
Thu May 16 10:01:48 AEST 2019


On 13/5/19 1:18 pm, Suraj Jitindar Singh wrote:
> Fast reboot gets disabled for a number of reasons e.g. the availability
> of nvlink. However this doesn't actually affect the ability to perform fast
> reboot if no nvlink device is actually present.

For the record, using current skiboots on P9, the NPU2 code *should* 
only disable fast reboot if an NVLink or OpenCAPI device is present. If 
you hit a situation where it's disabled without a device being present 
let me know.

On P8 I think you're right though.

> 
> Add a nvram option for fast-reset where if it's set to
> "im-feeling-lucky" then perform the fast-reboot irrespective of if it's
> previously been disabled.
> 
> Signed-off-by: Suraj Jitindar Singh <sjitindarsingh at gmail.com>
> ---
>   core/fast-reboot.c | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/core/fast-reboot.c b/core/fast-reboot.c
> index 22160b65..c4280149 100644
> --- a/core/fast-reboot.c
> +++ b/core/fast-reboot.c
> @@ -132,7 +132,12 @@ void fast_reboot(void)
>   		return;
>   	}
>   
> -	if (fast_reboot_disabled) {
> +	if (fast_reboot_disabled && nvram_query_eq("fast-reset",
> +						   "im-feeling-lucky")) {
> +		/* Do fast reboot even if it's been disabled */
> +		prlog(PR_NOTICE, "RESET: Ignoring fast reboot disabled: %s\n",
> +				fast_reboot_disabled);
> +	} else if (fast_reboot_disabled) {
>   		prlog(PR_NOTICE, "RESET: Fast reboot disabled: %s\n",
>   		      fast_reboot_disabled);
>   		opal_quiesce(QUIESCE_RESUME, -1);
> 

-- 
Andrew Donnellan              OzLabs, ADL Canberra
ajd at linux.ibm.com             IBM Australia Limited



More information about the Skiboot mailing list