[Skiboot] [PATCH v3 2/3] platforms/astbmc: Check for SBE validation step

[Andrew Jeffery]

On Tue, 7 May 2019, at 09:52, Samuel Mendoza-Jonas wrote:
> On Mon, 2019-05-06 at 03:43 -0400, Andrew Jeffery wrote:
> > 
> > On Tue, 30 Apr 2019, at 14:51, Samuel Mendoza-Jonas wrote:
> > > On some POWER8 astbmc systems an update to the SBE requires pausing at
> > > runtime to ensure integrity of the SBE. If this is required the BMC will
> > > set a chassis boot option IPMI flag using the OEM parameter 0x62. If
> > > Skiboot sees this flag is set it waits until the SBE update is complete
> > > and the flag is cleared.
> > > 
> > > Signed-off-by: Samuel Mendoza-Jonas <sam at mendozajonas.com>
> > > ---
> > > v3: Check location moved to just before kernel booting; otherwise the
> > > kernel image appears to be malformed somehow and we immediately reboot.
> > > v2: IPMI response format updated.
> > > This reflects functionality that will appear in new versions of AMI's
> > > and SMC's BMC implementations. The format of the IPMI response has been
> > > confirmed and testing is ongoing with both parties to verify the
> > > behaviour.
> > > 
> 
> I just realised you're reviewing v3 - there's a v4 which has some
> important differences (but you're comments will still apply).

Hrm, I wonder why I overlooked v4. If you can Cc me on v5 that would be great!

Andrew