[Skiboot] [PATCH v2 2/9] opal-msg: Pass return value to callback handler

Jeremy Kerr jk at ozlabs.org
Mon May 6 19:49:02 AEST 2019

Hi Vasant,

> Kernel calls opal_get_msg() API to read OPAL message. In this path
> calls "callback" handler to intimate caller that kernel read the opal
> message. It assumes that read is always success. This assumption was
> fine as message was always fixed size.

I think "inform the caller" might be a better choice of phrasing than
"intimate caller". I don't think that warrants re-sending the patch,
unless you're planning other changes.

> Next patch introduces variable size opal message. In that situation
> opal_get_msg() may fail due to insufficient buffer size (ex: old
> kernel
> and new OPAL combination). So lets add `return value` parameter to
> "callback"
> handler. So that caller knows kernel didn't read the message and take
> appropriate action.

Acked-by: Jeremy Kerr <jk at ozlabs.org>



More information about the Skiboot mailing list