[Skiboot] [PATCH v3 1/3] include/ipmi: Fix incorrect chassis commands

Andrew Jeffery andrew at aj.id.au
Mon May 6 15:42:49 AEST 2019



On Tue, 30 Apr 2019, at 14:51, Samuel Mendoza-Jonas wrote:
> These commands are listed in the order they appear in the IPMI
> specification but with the wrong values - correct them!
> 
> Signed-off-by: Samuel Mendoza-Jonas <sam at mendozajonas.com>

This is all very on-brand for IPMI.

Reviewed-by: Andrew Jeffery <andrew at aj.id.au>

> ---
>  include/ipmi.h | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/include/ipmi.h b/include/ipmi.h
> index 4999bb5a..da85c4b0 100644
> --- a/include/ipmi.h
> +++ b/include/ipmi.h
> @@ -47,13 +47,13 @@
>  #define IPMI_CHASSIS_CONTROL_CMD		0x02
>  #define IPMI_CHASSIS_RESET_CMD			0x03
>  #define IPMI_CHASSIS_IDENTIFY_CMD		0x04
> -#define IPMI_CHASSIS_SET_PANEL_BUTTON_EN_CMD	0x05
> -#define IPMI_CHASSIS_SET_CAP_CMD		0x06
> -#define IPMI_CHASSIS_SET_PWR_RESTORE_CMD	0x07
> -#define IPMI_CHASSIS_SET_PWR_CYCLE_CMD		0x08
> -#define IPMI_CHASSIS_GET_SYS_RESTART_CAUSE_CMD	0x09
> -#define IPMI_CHASSIS_SET_SYS_BOOT_OPT_CMD	0x0a
> -#define IPMI_CHASSIS_GET_SYS_BOOT_OPT_CMD	0x0b
> +#define IPMI_CHASSIS_SET_PANEL_BUTTON_EN_CMD	0x0a
> +#define IPMI_CHASSIS_SET_CAP_CMD		0x05
> +#define IPMI_CHASSIS_SET_PWR_RESTORE_CMD	0x06
> +#define IPMI_CHASSIS_SET_PWR_CYCLE_CMD		0x0b
> +#define IPMI_CHASSIS_GET_SYS_RESTART_CAUSE_CMD	0x07
> +#define IPMI_CHASSIS_SET_SYS_BOOT_OPT_CMD	0x08
> +#define IPMI_CHASSIS_GET_SYS_BOOT_OPT_CMD	0x09
>  #define IPMI_CHASSIS_GET_POH_COUNTER_CMD	0x0f
>  
>  
> -- 
> 2.21.0
> 
> _______________________________________________
> Skiboot mailing list
> Skiboot at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/skiboot
>


More information about the Skiboot mailing list