[Skiboot] [RFC PATCH] nvram: Flag dangerous NVRAM options

Stewart Smith stewart at linux.ibm.com
Fri May 3 16:12:25 AEST 2019


Oliver <oohall at gmail.com> writes:
>> +static void nvram_dangerous(const char *key)
>> +{
>> +       prlog(PR_ERR, " ___________________________________________________________\n");
>> +       prlog(PR_ERR, "<  Dangerous NVRAM option: %s\n", key);
>> +       prlog(PR_ERR, " -----------------------------------------------------------\n");
>> +       prlog(PR_ERR, "                  \\                         \n");
>> +       prlog(PR_ERR, "                   \\   WW                   \n");
>> +       prlog(PR_ERR, "                      <^ \\___/|             \n");
>> +       prlog(PR_ERR, "                       \\      /             \n");
>> +       prlog(PR_ERR, "                        \\_  _/              \n");
>> +       prlog(PR_ERR, "                          }{                 \n");
>> +}
>
> We're going to have a whole barnyard soon.

Not a terrible idea, helps narrow down bug reports that are suitably
*terribly* vague.



-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list