[Skiboot] [PATCH] astbmc: Handle failure to initialise raw flash

Stewart Smith stewart at linux.ibm.com
Fri Mar 29 15:59:30 AEDT 2019

"Andrew Jeffery" <andrew at aj.id.au> writes:
> On Wed, 20 Mar 2019, at 18:58, Vasant Hegde wrote:
>> On 03/20/2019 11:46 AM, Andrew Jeffery wrote:
>> > Initialising raw flash lead to a dead assignment to rc. Check the return
>> > code and take the failure path as necessary. Both before and after the
>> > fix we see output along the lines of the following when flash_init()
>> > fails:
>> If flash_init() fails, then we are sure we are going to crash at later 
>> stage.
>> May be we should assert() if falsh_init() fails. But that will change 
>> current flow.
>> Between I think this should go to Stable # 6.2.x. I will grab this patch for 
>> next stable release.
> Stewart and I were debating whether it should go to stable. If you're
> happy to pick it up I'm fine with that; we had concluded that it was
> somewhat cosmetic as things stand now.

Oh, I meant to mention, I'm going to *completely* leave that decision up
to Vasant to bikeshed. I'd err on the side of probably not bringing it
to stable, but there's an argument to be had to be more conservative and
die reliably in the first place you know there's trouble if only to
avoid some crazy problem we haven't yet thought of/discovered.

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list