[Skiboot] [PATCH 1/3] npu2-hw-procedures: Don't set iovalid for opencapi devices

christophe lombard clombard at linux.vnet.ibm.com
Tue Mar 26 02:31:11 AEDT 2019

On 15/03/2019 17:44, Frederic Barrat wrote:
> set_iovalid() is called on the PHY reset path. The hw logic it touches
> is meaningless for opencapi. It's not hurting as long as all the links
> under the NPU are in opencapi mode, but in case of mixing opencapi and
> nvlink, we'll be in troubles: the code finds which bit to modify based
> on the brick index, which varies depending on the mode. So calling
> that function on an opencapi device may modify a nvlink brick! For
> example, for brick index 3.
> So we simply avoid doing anything when calling set_iovalid() for an
> opencapi device.
> Signed-off-by: Frederic Barrat <fbarrat at linux.ibm.com>
> ---

Reviewed-by: Christophe Lombard <clombard at linux.vnet.ibm.com>

More information about the Skiboot mailing list