[Skiboot] [PATCH 1/7] hw/npu2: Fix OpenCAPI PE assignment

christophe lombard clombard at linux.vnet.ibm.com
Tue Mar 26 02:27:11 AEDT 2019


On 20/03/2019 19:35, Frederic Barrat wrote:
> From: Andrew Donnellan <andrew.donnellan at au1.ibm.com>
> 
> When we support mixing NVLink and OpenCAPI devices on the same NPU, we're
> going to have to share the same range of 16 PE numbers between NVLink and
> OpenCAPI PHBs.
> 
> For OpenCAPI devices, PE assignment is only significant for determining
> which System Interrupt Log register is used for a particular brick - unlike
> NVLink, it doesn't play any role in determining how links are fenced.
> 
> Split the PE range into a lower half which is used for NVLink, and an upper
> half that is used for OpenCAPI, with a fixed PE number assigned per brick.
> 
> As the PE assignment for OpenCAPI devices is fixed, set the PE once
> during device init and then ignore calls to the set_pe() operation.
> 
> Suggested-by: Frederic Barrat <fbarrat at linux.ibm.com>
> Signed-off-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>
> ---
>   hw/npu2-opencapi.c | 74 +++++++++++++++++++++-------------------------
>   include/npu2.h     | 21 +++++++++++--
>   2 files changed, 52 insertions(+), 43 deletions(-)
> 

Reviewed-by: Christophe Lombard <clombard at linux.vnet.ibm.com>



More information about the Skiboot mailing list