[Skiboot] [PATCH] hw/npu2: Merge reset functions
fbarrat at linux.ibm.com
Mon Mar 25 21:12:49 AEDT 2019
Le 22/03/2019 à 22:15, Reza Arbab a écrit :
> On Fri, Mar 22, 2019 at 04:45:23PM +1100, Oliver O'Halloran wrote:
>> static int64_t npu2_freset(struct pci_slot *slot __unused)
>> - return OPAL_SUCCESS;
>> + return npu2_reset("Freset");
> IIRC, there actually is a reason npu2_freset() doesn't do anything.
> Alistair, do you recall?
I'm certainly not trying to fill-in for Alistair ;-) but freset is
called when the PCI slots are init when skiboot starts, typically to
kick-in link training. Except for nvlink. So here we'd be resetting the
NTL instead of doing nothing. Any chance it could have consequences?
More information about the Skiboot