[Skiboot] [PATCH 10/15] external/trace: Fix endianness detection in Makefile

Oliver oohall at gmail.com
Mon Mar 25 12:38:49 AEDT 2019


On Mon, Mar 25, 2019 at 11:18 AM Jordan Niethe <jniethe5 at gmail.com> wrote:
>
> The Makefile for the dump_trace tool does not correctly determine
> endianness on Power. Instead Big Endian is always used on Power. Fix so
> Little Endian will be detected.
> ---
>  external/trace/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/external/trace/Makefile b/external/trace/Makefile
> index 3b6684bf1f4d..3828fea534ea 100644
> --- a/external/trace/Makefile
> +++ b/external/trace/Makefile
> @@ -1,4 +1,4 @@
> -HOSTEND=$(shell uname -m | sed -e 's/^i.*86$$/LITTLE/' -e 's/^x86.*/LITTLE/' -e 's/^ppc.*/BIG/')
> +HOSTEND=$(shell uname -m | sed -e 's/^i.*86$$/LITTLE/' -e 's/^x86.*/LITTLE/' -e 's/^ppc64le/LITTLE/' -e 's/^ppc.*/BIG/')
>  CFLAGS=-g -Wall -DHAVE_$(HOSTEND)_ENDIAN -I../../include -I../../

lol, been a while since we used this...

Reviewed-by: Oliver O'Halloran <oohall at gmail.com>

>
>  dump_trace: dump_trace.c
> --
> 2.20.1
>
> _______________________________________________
> Skiboot mailing list
> Skiboot at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/skiboot


More information about the Skiboot mailing list