[Skiboot] [PATCH 04/15] core/trace: Put boot_tracebuf in correct location.

Jordan Niethe jniethe5 at gmail.com
Mon Mar 25 11:14:14 AEDT 2019


A position for the boot_tracebuf is allocated in skiboot.lds.S.
However, without a __section attribute the boot trace buffer is not
placed in the correct location, meaning that it also will not be
correctly aligned.  Adding the __section attribute ensures that that
will happen.
---
 core/trace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/core/trace.c b/core/trace.c
index e1d5c32aede4..64a64bd7c35c 100644
--- a/core/trace.c
+++ b/core/trace.c
@@ -35,7 +35,7 @@
 static struct {
 	struct trace_info trace_info;
 	char buf[TBUF_SZ + MAX_SIZE];
-} boot_tracebuf;
+} boot_tracebuf __section(".data.boot_trace");
 
 void init_boot_tracebuf(struct cpu_thread *boot_cpu)
 {
-- 
2.20.1



More information about the Skiboot mailing list