[Skiboot] [PATCH] astbmc: Handle failure to initialise raw flash

Andrew Jeffery andrew at aj.id.au
Wed Mar 20 19:34:45 AEDT 2019

On Wed, 20 Mar 2019, at 18:58, Vasant Hegde wrote:
> On 03/20/2019 11:46 AM, Andrew Jeffery wrote:
> > Initialising raw flash lead to a dead assignment to rc. Check the return
> > code and take the failure path as necessary. Both before and after the
> > fix we see output along the lines of the following when flash_init()
> > fails:
> If flash_init() fails, then we are sure we are going to crash at later 
> stage.
> May be we should assert() if falsh_init() fails. But that will change 
> current flow.
> Between I think this should go to Stable # 6.2.x. I will grab this patch for 
> next stable release.

Stewart and I were debating whether it should go to stable. If you're happy to pick it up I'm fine with that; we had concluded that it was somewhat cosmetic as things stand now.


> -Vasant

More information about the Skiboot mailing list