[Skiboot] [PATCH v2 7/7] npu2-opencapi: Fix adapter reset when using 2 adapters
christophe lombard
clombard at linux.vnet.ibm.com
Tue Mar 19 19:09:30 AEDT 2019
On 12/03/2019 21:35, Frederic Barrat wrote:
> If two opencapi adapters are on the same obus, we may try to train the
> two links in parallel at boot time, when all the PCI links are being
> trained. Both links use the same i2c controller to handle the reset
> signal, so some care is needed to make sure resetting one doesn't
> interfere with the reset of the other. We need to keep track of the
> current state of the i2c controller (and use locking).
>
> This went mostly unnoticed as you need to have 2 opencapi cards on the
> same socket and links tended to train anyway because of the retries.
>
> Signed-off-by: Frederic Barrat <fbarrat at linux.ibm.com>
> Reviewed-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>
> ---
>
> v2: no change
>
> hw/npu2-common.c | 3 +++
> hw/npu2-opencapi.c | 34 +++++++++++++++++++++++++++-------
> include/npu2.h | 4 ++++
> 3 files changed, 34 insertions(+), 7 deletions(-)
>
Reviewed-by: Christophe Lombard <clombard at linux.vnet.ibm.com>
More information about the Skiboot
mailing list