[Skiboot] [PATCH 1/2] fast-reboot: occ: Remove 'freq-domain-mask' from fast-reboot path

[Vasant Hegde]

On 03/06/2019 02:53 PM, Shilpasri G Bhat wrote:
> OCC can change the pstate table at runtime to modify pstate limits or
> for characterization purpose. These changes are reflected by re-parsing
> the pstate table during fast-reboot to update the device-tree. Only
> relevant pstate DT properties are deleted and newly added during
> fast-reboot. The device-tree properties like 'freq-domain-mask' and
> 'domain-runs-at' are currently hard-coded and need not be updated
> during fast-reboot. So this patch removes them from the fast-reboot path.
> 
> This patch fixes the below crash:
> [  270.313998453,5] OCC: All Chip Rdy after 0 ms
> [  270.314148918,3] Duplicate property "freq-domain-mask" in node /ibm,opal/power-mgt
> [  270.314208553,0] Aborting!
> CPU 083c Backtrace:
>   S: 0000000035de3a20 R: 000000003001b480   ._abort+0x4c
>   S: 0000000035de3aa0 R: 0000000030028704   .new_property+0xd8
>   S: 0000000035de3b30 R: 0000000030028964   .__dt_add_property_cells+0x30
>   S: 0000000035de3bd0 R: 0000000030042980   .occ_pstates_init+0x7c8
>   S: 0000000035de3d90 R: 00000000300145f4   .load_and_boot_kernel+0x980
>   S: 0000000035de3e70 R: 00000000300276b4   .fast_reboot_entry+0x37c
>   S: 0000000035de3f00 R: 0000000030002ac4   reset_fast_reboot_wakeup+0x40
> 
> Fixes: b821f8c2a8e3("power-mgmt : occ : Add 'freq-domain-mask' DT property")
> Reported-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
> Signed-off-by: Shilpasri G Bhat <shilpa.bhat at linux.vnet.ibm.com>

Looks good to me. This patch fixes ZZ fast-reboot issue.


Tested-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>

-Vasant