[Skiboot] [PATCH 1/7] npu2-opencapi: Rework ODL register access

christophe lombard clombard at linux.vnet.ibm.com
Tue Mar 12 20:21:14 AEDT 2019


On 01/03/2019 14:52, Frederic Barrat wrote:
> ODL registers used to control the opencapi link state have an address
> built on a base address and an offset for each brick which can be
> computed instead of hard-coded individually for each brick.
> Rework how we access the ODL registers, to avoid repeating switch
> statements all over the place.
> 
> Signed-off-by: Frederic Barrat <fbarrat at linux.ibm.com>
> ---
>   hw/npu2-hw-procedures.c |  17 +------
>   hw/npu2-opencapi.c      | 109 ++++------------------------------------
>   include/npu2-regs.h     |  30 ++++-------
>   3 files changed, 21 insertions(+), 135 deletions(-)
> 

why do not move the definition of these scom registers
to xscom-p9-regs.h ?
May be with the development of opencapi4.

Reviewed-by: Christophe Lombard <clombard at linux.vnet.ibm.com>



More information about the Skiboot mailing list