[Skiboot] [PATCH 7/7] npu2-opencapi: Fix adapter reset when using 2 adapters

Andrew Donnellan andrew.donnellan at au1.ibm.com
Tue Mar 12 10:30:56 AEDT 2019

On 11/3/19 8:02 pm, Frederic Barrat wrote:
>>> +static void assert_adapter_reset(struct npu2_dev *dev)
>>> +{
>>> +    uint8_t pin, data;
>> Any reason to keep data around instead of just referencing dev->npu->* 
>> directly?
> No reason, I just thought the code would be a bit more readable by 
> spelling out what we pass to the underlying i2c layer. Let me know how 
> strongly you object.

Not very :)

Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan at au1.ibm.com  IBM Australia Limited

More information about the Skiboot mailing list