[Skiboot] [PATCH 5/7] npu2-opencapi: ODL should be in reset when enabled

Frederic Barrat fbarrat at linux.ibm.com
Sat Mar 2 00:52:37 AEDT 2019


We haven't hit any problem so far, but from the ODL designer, the ODL
should be in reset when it is enabled.

Signed-off-by: Frederic Barrat <fbarrat at linux.ibm.com>
---
 hw/npu2-opencapi.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/hw/npu2-opencapi.c b/hw/npu2-opencapi.c
index 1cdae100..a0c1dba1 100644
--- a/hw/npu2-opencapi.c
+++ b/hw/npu2-opencapi.c
@@ -308,6 +308,12 @@ static void enable_odl_phy_mux(uint32_t gcid, int index)
 		assert(false);
 	}
 
+	/*
+	 * ODL must be in reset when enabling.
+	 * It stays in reset until the link is trained
+	 */
+	assert_odl_reset(gcid, index);
+
 	/* PowerBus OLL PHY Training Config Register */
 	xscom_read(gcid, phy_config_scom, &reg);
 
-- 
2.19.1



More information about the Skiboot mailing list