[Skiboot] [PATCH v8 24/24] MPIPL: Add documentation

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Fri Jun 28 20:24:29 AEST 2019

On 06/28/2019 07:20 AM, Nicholas Piggin wrote:
> Vasant Hegde's on June 17, 2019 3:10 am:
>> Document MPIPL device tree and OPAL APIs.
>> Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
>> Signed-off-by: Ananth N Mavinakayanahalli <ananth at linux.vnet.ibm.com>
> I guess you've got the documentation here. That's probably fine.
> I do like patches adding documentation as they add the interfaces
> just because it makes it nicer to review, but that's a small
> quibble.

Ideally yes. I should have added this along with patch.
I just wanted to add all documentation in one place. Also I tried to make sure
DT/API related patches contains enough description to understand the patch.

Unless I get strong objection I'm not going to change this.

> In general the series looks pretty good to me now, I have no
> fundamental objections to the concept or interfaces at a high level.



More information about the Skiboot mailing list