[Skiboot] [PATCH 5/7] npu2: Add checks to npu2-only codepaths

Alexey Kardashevskiy aik at ozlabs.ru
Wed Jun 26 15:15:18 AEST 2019

On 18/06/2019 17:17, Andrew Donnellan wrote:
> On 18/6/19 5:12 pm, Alexey Kardashevskiy wrote:> probe_npu2() will probe
> npu3 and probe_npu3() will probe npu3? Quite
>> confusing. And thers is also probe_npu() - is that guy expected to probe
>> npu1, npu2, npu3?
> No it doesn't, probe_npu2() is npu2 only, probe_npu3() is npu3 only.
> They use different device tree compat strings.

A slightly strange pattern then. probe_npu2() is called on every
machine, including POWER8NVL. It does not do anything because
platform.npu2_device_detect is not defined there. Ahhh whatever...


More information about the Skiboot mailing list