[Skiboot] [PATCH] platform/zz: Add new platform type

Stewart Smith stewart at linux.ibm.com
Tue Jun 25 13:25:03 AEST 2019


"Oliver O'Halloran" <oohall at gmail.com> writes:
> On Mon, Jun 24, 2019 at 6:43 PM Vasant Hegde
> <hegdevasant at linux.vnet.ibm.com> wrote:
>>
>> We have new platform type under ZZ. Lets add them. With this fix
>> we are able to boot the system.
>>
>> Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
>> ---
>>  platforms/ibm-fsp/zz.c | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/platforms/ibm-fsp/zz.c b/platforms/ibm-fsp/zz.c
>> index 705906a04..96259c35b 100644
>> --- a/platforms/ibm-fsp/zz.c
>> +++ b/platforms/ibm-fsp/zz.c
>> @@ -51,7 +51,10 @@ static bool zz_probe(void)
>>         if (dt_node_is_compatible(dt_root, "ibm,zz-1s2u") ||
>>             dt_node_is_compatible(dt_root, "ibm,zz-1s4u") ||
>>             dt_node_is_compatible(dt_root, "ibm,zz-2s2u") ||
>> -           dt_node_is_compatible(dt_root, "ibm,zz-2s4u"))
>> +           dt_node_is_compatible(dt_root, "ibm,zz-2s4u") ||
>> +           dt_node_is_compatible(dt_root, "ibm,zz-1s4u+gen4") ||
>> +           dt_node_is_compatible(dt_root, "ibm,zz-2s2u+gen4") ||
>> +           dt_node_is_compatible(dt_root, "ibm,zz-2s4u+gen4"))
>>                 return true;
>
> I'm starting to think we might be better off just using strncmp() and
> looking at the "ibm,zz" prefix. Oh well.

Although, failing to boot *does* end up letting us know that new
machines exist. Otherwise people don't tell us, and will probably just
ship them.

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list