[Skiboot] [PATCH] struct p9_sbe_msg doesn't need to be packed

Stewart Smith stewart at linux.ibm.com
Wed Jun 19 14:51:04 AEST 2019


Stewart Smith <stewart at linux.ibm.com> writes:
> Only the reg member is sent anywhere (via xscom_write), so the structure
> does not need to be packed.
>
> Fixes GCC9 build problem:
> hw/sbe-p9.c: In function ‘p9_sbe_msg_send’:
> hw/sbe-p9.c:270:9: error: taking address of packed member of ‘struct p9_sbe_msg’ may result in an unaligned pointer value [-Werror=address-of-packed-member]
>   270 |  data = &msg->reg[0];
>       |         ^~~~~~~~~~~~
>
> Signed-off-by: Stewart Smith <stewart at linux.ibm.com>
> ---
>  include/sbe-p9.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Merged to master as of ef691db3533742d9dd6eed1a311472a7c52be94b

-- 
Stewart Smith
OPAL Architect, IBM.


More information about the Skiboot mailing list