[Skiboot] [PATCH 4/7] npu2: Refactor NPU OPAL calls

[Andrew Donnellan]

On 13/6/19 7:08 am, Reza Arbab wrote:
> Abstract the OPAL entry points for npu2, moving them to a new file. This
> prepares us to add parallel npu3 versions of the same APIs.
> 
> No functional change.
> 
> Signed-off-by: Reza Arbab <arbab at linux.ibm.com>


> +static int64_t npu_set_relaxed_order(uint32_t gcid, int pec, bool enable)
> +{
> +	struct phb *phb;
> +	uint64_t rc;

This should be signed.

Otherwise:

Reviewed-by: Andrew Donnellan <ajd at linux.ibm.com>

> +
> +	for_each_phb(phb) {
> +		if (phb->phb_type != phb_type_npu_v2)
> +			continue;
> +
> +		rc = npu2_set_relaxed_order(phb, gcid, pec, enable);
> +		if (rc)
> +			return rc;
> +	}
> +
> +	return OPAL_SUCCESS;
> +}
> +

-- 
Andrew Donnellan              OzLabs, ADL Canberra
ajd at linux.ibm.com             IBM Australia Limited