[Skiboot] [PATCH 7/7] Add Swift platform

Reza Arbab arbab at linux.ibm.com
Fri Jun 14 00:52:46 AEST 2019


On Thu, Jun 13, 2019 at 10:59:22AM +1000, Michael Neuling wrote:
>On Wed, 2019-06-12 at 16:08 -0500, Reza Arbab wrote:
>> +	if (nr_chips() != 2 || npu3_chip_possible_gpus() != 2) {
>> +		prlog(PR_ERR, "NPU: Unknown link topology detected\n");
>> +		return;
>> +	}
>
>Anyway we can support 1 chip?  Especially early on we have systems populated
>with just 1 chip and it's nice to still be able to work there.
>
>I guess we still boot, we just don't get NPUs.

This was just sort of a clunky sanity check that we're really on a 
four-GPU capable system. It didn't occur to me that a Swift might only 
have one chip.

Checking that we're a two-GPU per chip system is good enough, so I'll 
just drop the nr_chips() part.

-- 
Reza Arbab


More information about the Skiboot mailing list