[Skiboot] [PATCH] npu2-opencapi: Mask 2 XSL errors
stewart at linux.ibm.com
Wed Jun 5 11:37:29 AEST 2019
Frederic Barrat <fbarrat at linux.ibm.com> writes:
> Commit f8dfd699f584 ("hw/npu2: Setup an error interrupt on some
> opencapi FIRs") converted some FIR bits default action from system
> checkstop to raising an error interrupt. For 2 XSL error events that
> can be triggered by a misbehaving AFU, the error interrupt is raised
> twice, once for each link (the XSL logic in the NPU is shared between
> 2 links). So a badly behaving AFU could impact another, unsuspecting
> opencapi adapter.
> It doesn't look good and it turns out we can do better. We can mask
> those 2 XSL errors. The error will also be picked up by the OTL logic,
> which is per link. So we'll still get an error interrupt, but only on
> the relevant link, and the other opencapi adapter can stay functional.
> Fixes: f8dfd699f584 ("hw/npu2: Setup an error interrupt on some opencapi FIRs")
> Signed-off-by: Frederic Barrat <fbarrat at linux.ibm.com>
> hw/npu2-opencapi.c | 29 ++++++++++++++++++++---------
> 1 file changed, 20 insertions(+), 9 deletions(-)
Thanks, merged to master as of ce49505c2fafabc0fa4a4a5d1e34f6dd2dd7fb8f
OPAL Architect, IBM.
More information about the Skiboot