[Skiboot] [RFC PATCH 4/6] opal/errorlog: Add support to include callout section in error log.

Stewart Smith stewart at linux.ibm.com
Tue Jun 4 14:18:00 AEST 2019


Mahesh Salgaonkar <mahesh at linux.vnet.ibm.com> writes:
> Allow inclusion of HW callout to eSEL being generated. This will help OPAL
> to generate errorlog with fru callout section that includes location code,
> part number and serial number of a faulty hardware that may need replacement.
>
> Signed-off-by: Mahesh Salgaonkar <mahesh at linux.vnet.ibm.com>
> ---
>  core/errorlog.c    |   32 ++++++++++++++++++++++
>  core/pel.c         |   77 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>  include/errorlog.h |    9 ++++++
>  include/pel.h      |   68 ++++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 186 insertions(+)

It's probably worth extending core/test/run-pel.c to cover these cases.

It may also be worth modifying that test to ensure we actually generate
something that makes sense rather than just assuming success.

-- 
Stewart Smith
OPAL Architect, IBM.


More information about the Skiboot mailing list