[Skiboot] [PATCH skiboot] npu2: Fix clearing the FIR bits
stewart at linux.ibm.com
Mon Jun 3 12:05:23 AEST 2019
Alistair Popple <alistair at popple.id.au> writes:
> On Monday, 20 May 2019 3:32:48 PM AEST Andrew Donnellan wrote:
>> On 20/5/19 3:32 pm, Andrew Donnellan wrote:
>> > On 20/5/19 2:22 pm, Alexey Kardashevskiy wrote:
>> >> FIR registers are SCOM-only so they cannot be accesses with the indirect
>> >> write, and yet we use SCOM-based addresses for these; fix this.
>> >> Signed-off-by: Alexey Kardashevskiy <aik at ozlabs.ru>
>> > Oh yes that current code looks VERY wrong.
>> > Reviewed-by: Andrew Donnellan <ajd at linux.ibm.com>
>> (does this need to go to stable?)
> Probably. I'm not sure how this hasn't caused any issues before now.
Okay. Vasant, can you be sure to pick this up? I've merged it to master
as of 5ed3884f8d04db684e2288a7db011c7b59f1501e
OPAL Architect, IBM.
More information about the Skiboot