[Skiboot] [PATCH] Makefiles: Remove --Wno-stringop-truncation
oohall at gmail.com
Fri Jul 26 16:04:34 AEST 2019
On Fri, Jul 26, 2019 at 3:55 PM Stewart Smith <stewart at linux.ibm.com> wrote:
> "Oliver O'Halloran" <oohall at gmail.com> writes:
> > To disable a warning you use the command line parameter:
> > -Wno-<warning-name>, not
> > --Wno-<warning-name>
> > GCC seems to ignore parameters starting with a double dash, so we've
> > been building with the stringop-trunction warning enabled for about a
> > year now and no one has complained. Away it goes.
> I think Joel originally submitted this... probably for some reason, but
> maybe that reason was only valid on a weird toolchain that was looking
> at him funny that day? Or we solidly messed it up.
You added it in commit 918b7233d3bb ("Add -Wno-stringop-truncation for
GCC8") since we compile with -Werror and it was a spurious warning.
Joel added the try-cflag check in cd2b103f2488 ("Makefile: Check
-Wno-stringop-truncation is supported") because his compiler (GCC7?)
didn't have -Wno-stringop-truncation and threw and error because of
it. Joel's patch added the --, so we've been compiling with it enabled
for a while now.
More information about the Skiboot