[Skiboot] [PATCH 1/3] pci-quirk: Re-order struct members

Oliver O'Halloran oohall at gmail.com
Wed Jul 24 11:58:51 AEST 2019

On Wed, Jul 24, 2019 at 11:27 AM Alistair Popple <alistair at popple.id.au> wrote:
> I'm curious, why are you re-ordering the struct members?

Oh whoops, the commit message went AWOL.

Having the function first means the vendor and device IDs will be
unaligned unless the function names are the same length (or padded
out) and that just won't do.

> Also you need to update the quirk table in core/test/run-pci-quirk.c. Other
> than that this looks ok though so once that's fixed you can add:

ah yeah, good point.

> Reviewed-by: Alistair Popple <alistair at popple.id.au>

More information about the Skiboot mailing list