[Skiboot] [PATCH v3 3/3] Modify: modify copyright statement in mihawk platform file

Michael Neuling mikey at neuling.org
Thu Jul 18 17:56:18 AEST 2019


On Wed, 2019-07-17 at 14:09 +0530, Vasant Hegde wrote:
> On 07/17/2019 01:06 PM, joy_chu at wistron.com wrote:
> > From: joy_chu <joy_chu at wistron.com>
> > 
> > Signed-off-by: joy_chu <joy_chu at wistron.com>
> > ---
> >   platforms/astbmc/mihawk.c | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/platforms/astbmc/mihawk.c b/platforms/astbmc/mihawk.c
> > index ee1e4d2..833528e 100644
> > --- a/platforms/astbmc/mihawk.c
> > +++ b/platforms/astbmc/mihawk.c
> > @@ -1,4 +1,5 @@
> > -/* Copyright 2017 IBM Corp.
> > +/* Copyright 2019 Wistron Corp.
> > + * Copyright 2017 IBM Corp.
> 
> Just adding copyright here without real code change doesn't look good.
> Better make this change in first patch itself?

Yep, same for patch 2. This should just be 1 patch not 3.

Mikey



More information about the Skiboot mailing list