[Skiboot] [PATCH] refer only objects not sources for getscom
Vasant Hegde
hegdevasant at linux.vnet.ibm.com
Wed Jul 17 19:35:06 AEST 2019
On 07/16/2019 01:26 PM, Dan Horák wrote:
> The rule for getscom binary should depend on object files only, not sources.
>
> Patch from Than Ngo <than[at]redhat.com>
Then add his s-o-b ?
Otherwise patch looks good to me.
Reviewed-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
-Vasant
>
> Signed-off-by: Dan Horák <dan at danny.cz>
> ---
> external/xscom-utils/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/external/xscom-utils/Makefile b/external/xscom-utils/Makefile
> index 795ce8fb..2eda4ea4 100644
> --- a/external/xscom-utils/Makefile
> +++ b/external/xscom-utils/Makefile
> @@ -21,7 +21,7 @@ endif
>
> all: getscom putscom getsram
>
> -getscom: getscom.c xscom.o version.o
> +getscom: getscom.o xscom.o version.o
> $(Q_LINK)$(LINK.o) -o $@ $^
>
> getsram: getsram.o xscom.o sram.o version.o
>
More information about the Skiboot
mailing list