[Skiboot] [PATCH] fix opal-gard installation rule

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Wed Jul 17 18:28:21 AEST 2019


On 07/16/2019 01:05 PM, Dan Horák wrote:
> Use $(EXE) for the binary name instead of hard-coding. This completes
> the "gard: Use consistent name" change from commit 41109e5073bdd7eaf7da9eb81c824f3d79073881

Sorry. I broke this :-(

Thanks for the fix. Looks good to me.

Reviewed-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>

-Vasant

> 
> Signed-off-by: Dan Horák <dan at danny.cz>
> ---
>   external/gard/rules.mk | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/external/gard/rules.mk b/external/gard/rules.mk
> index 522b16f8..9e8b5813 100644
> --- a/external/gard/rules.mk
> +++ b/external/gard/rules.mk
> @@ -44,7 +44,7 @@ $(EXE): $(OBJS)
>   	$(CC) $(LDFLAGS) $(CFLAGS) $^ -o $@
>   
>   install: all
> -	install -D gard $(DESTDIR)$(sbindir)/opal-gard
> -	install -D -m 0644 opal-gard.1 $(DESTDIR)$(mandir)/man1/opal-gard.1
> +	install -D $(EXE) $(DESTDIR)$(sbindir)/$(EXE)
> +	install -D -m 0644 $(EXE).1 $(DESTDIR)$(mandir)/man1/$(EXE).1
>   
>   
> 



More information about the Skiboot mailing list