[Skiboot] [PATCH 1/2] Add: add mihawk platform file

[Frederic Barrat]

Hi Hank, Joy,

Could you shed some light here? did we change the compatible string from 
"wistron,mihawk" to "ibm,mihawk" on the full stack and I was just 
unlucky to run a new skiboot on an old hostboot, or do we have 2 
different systems in the wild?
 From what I know, the mihawk I was using is an older generation, it has 
been in the IBM Austin lab for at least a year.

   Fred


Le 15/07/2019 à 03:41, Stewart Smith a écrit :
> Frederic Barrat <fbarrat at linux.ibm.com> writes:
>> Le 12/07/2019 à 04:04, HankChang a écrit :
>>> From: joy_chu <joy_chu at wistron.com>
>>> +static bool mihawk_probe(void)
>>> +{
>>> +	if (!dt_node_is_compatible(dt_root, "ibm,mihawk"))
>>
>>
>> On the mihawk system I tried, the fw is reporting "wistron,mihawk" in
>> the device tree, so I had to modify this patch. Which string is
>> correct?
> 
> https://raw.githubusercontent.com/open-power/mihawk-xml/master/mihawk.xml
> has "ibm,mihawk" and no sign of "wistron,mihawk".
> 
> So, I'm not sure if these are the same system or not here, nor what
> differences could be
> 
>> For the record, that system was installed with:
>> open-power-mihawk-v93.5.1_Imp_sign
>>           op-build-v2.3-rc2
>>           buildroot-2019.02.1-16-ge01dcd0
>>           skiboot-v6.3-rc1-pa9ddc35
>>           hostboot-e5622fb
>>           occ-58e422d
>>           linux-5.0.5-openpower1-p146a364
>>           petitboot-v1.10.3
>>           machine-xml-176b3d9
>>           hostboot-binaries-hw021419a.930
>>           capp-ucode-p9-dd2-v4
>>           sbe-1410677
>>           hcode-hw040319a.940
> 
> Hopefully they're not shipping with release candidate firmware :)
> 
> 
> I'm happy to take the patch as-is (there's a Copyright clarification I
> want beforehand though, see other mail).
>