[Skiboot] [PATCH] libflash: Fix broken continuations

Stewart Smith stewart at linux.ibm.com
Tue Jul 16 16:40:50 AEST 2019


"Oliver O'Halloran" <oohall at gmail.com> writes:
> Some of the libflash debug messages don't print a newlines at the end of
> the line and assume that the next print will be contigious with the
> last. This isn't true in skiboot since log messages are prefixed with a
> timestamp. This results in funny looking output such as:
>
> LIBFLASH: Verifying...
> LIBFLASH:   reading page 0x01963000..0x01964000...[3.084846885,7]  same !
> LIBFLASH:   reading page 0x01964000..0x01965000...[3.086164489,7]  same !
>
> Fix this by moving the "same !" debug message to a new line with the
> prefix "LIBFLASH:   ..." to indicate it's a continuation of the last
> statement.
>
> First reported in https://github.com/open-power/skiboot/issues/51
>
> Reported-by: Joel Stanley <joel at jms.id.au>
> Signed-off-by: Oliver O'Halloran <oohall at gmail.com>

Merged to master as of e4203d350e03b26780843655b3c8a7df5faae1e8
-- 
Stewart Smith
OPAL Architect, IBM.


More information about the Skiboot mailing list