[Skiboot] [PATCH v2 1/8] Dedup $(HW_OBJS)

Andrew Donnellan ajd at linux.ibm.com
Tue Jul 9 13:14:47 AEST 2019


On 9/7/19 7:07 am, Reza Arbab wrote:
> How did I notice one dup in aa56d9a2abdb ("Remove duplicate npu-common.o
> from $(HW_OBJS)"), but not the other five? Remove them too.
> 
> Signed-off-by: Reza Arbab <arbab at linux.ibm.com>

And apparently I haven't noticed any of them every time I've looked at 
that makefile...

Reviewed-by: Andrew Donnellan <ajd at linux.ibm.com>

> ---
>   hw/Makefile.inc | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/hw/Makefile.inc b/hw/Makefile.inc
> index 0e8c257fb80a..b6727bdfc133 100644
> --- a/hw/Makefile.inc
> +++ b/hw/Makefile.inc
> @@ -6,10 +6,8 @@ HW_OBJS += nx.o nx-rng.o nx-crypto.o nx-compress.o nx-842.o nx-gzip.o
>   HW_OBJS += phb3.o sfc-ctrl.o fake-rtc.o bt.o p8-i2c.o prd.o
>   HW_OBJS += dts.o lpc-rtc.o npu.o npu-hw-procedures.o xive.o phb4.o
>   HW_OBJS += fake-nvram.o lpc-mbox.o npu2.o npu2-hw-procedures.o
> -HW_OBJS += npu2-common.o phys-map.o sbe-p9.o capp.o occ-sensor.o vas.o
> -HW_OBJS += npu2-opencapi.o phys-map.o sbe-p9.o capp.o occ-sensor.o
> -HW_OBJS += vas.o sbe-p8.o dio-p9.o
> -HW_OBJS += lpc-port80h.o
> +HW_OBJS += npu2-common.o npu2-opencapi.o phys-map.o sbe-p9.o capp.o
> +HW_OBJS += occ-sensor.o vas.o sbe-p8.o dio-p9.o lpc-port80h.o
>   HW=hw/built-in.a
>   
>   include $(SRC)/hw/fsp/Makefile.inc
> 

-- 
Andrew Donnellan              OzLabs, ADL Canberra
ajd at linux.ibm.com             IBM Australia Limited



More information about the Skiboot mailing list